Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] test driver CI #2253

Closed
wants to merge 1 commit into from
Closed

[WIP] test driver CI #2253

wants to merge 1 commit into from

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97
tmp
f7b1627 
Signed-off-by: Andrea Terzolo <[email protected]>
@poiana
Copy link
Contributor

poiana commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from hbrueckner and incertum January 23, 2025 07:51
@Andreagit97 Andreagit97 marked this pull request as draft January 23, 2025 07:51
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     8.15%     -0.78%  [.] sinsp_evt::get_type
    10.57%     +0.64%  [.] sinsp::next
    10.73%     -0.58%  [.] sinsp_parser::reset
     5.29%     +0.51%  [.] next_event_from_file
     0.79%     +0.35%  [.] sinsp_evt::get_direction
     3.16%     -0.34%  [.] sinsp_thread_manager::get_thread_ref
     0.74%     -0.30%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     1.43%     -0.27%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.79%     -0.25%  [.] sinsp_evt::load_params
     2.89%     -0.24%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0045         +0.0045           144           145           144           145
BM_sinsp_split_median                                          +0.0060         +0.0060           144           145           144           145
BM_sinsp_split_stddev                                          +0.7941         +0.7936             1             2             1             2
BM_sinsp_split_cv                                              +0.7861         +0.7856             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0830         +0.0830            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0820         +0.0820            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_stddev                +0.9112         +0.9128             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.7646         +0.7662             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0430         -0.0430            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0401         -0.0401            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5655         -0.5659             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5460         -0.5464             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1157         +0.1157            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.1202         +0.1202            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.1693         +0.1691             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.0480         +0.0479             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0082         -0.0082           389           386           389           386
BM_sinsp_split_container_image_median                          -0.0123         -0.0123           389           384           389           384
BM_sinsp_split_container_image_stddev                          +0.0211         +0.0207             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.0295         +0.0292             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (6c46ed3) to head (f7b1627).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2253   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         278      278           
  Lines       34478    34478           
  Branches     5922     5922           
=======================================
  Hits        25916    25916           
  Misses       8562     8562
Flag Coverage Δ
libsinsp 75.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@incertum incertum Awaiting requested review from incertum

Assignees
No one assigned
Labels
approved dco-signoff: yes do-not-merge/work-in-progress release-note-none size/XS
Projects
Falco Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andreagit97 @poiana